FIX: Import location of HF hub errors #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves huggingface#2097 This fix should make the import of the huggingface_hub error work with older versions of that package.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Also set min version to 0.25.0
|
Thanks @Wauplin. I was unsure what the best way to import would be in the future. I now switched to importing from |
Wauplin
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for the update @BenjaminBossan!
Yes 0.25.0 is the lowest possible release that supports it.
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 29, 2024
Resolves huggingface#2097 Import errors from huggingface_hub.errors Also set min version to 0.25.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2097
This fix should make the import of the
huggingface_huberror work with older versions of that package.