Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add saving safety_checker #990

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Nov 7, 2024

What does this PR do?

safety_checker is part of pipeline for sd and sdxl models family. In case, if we provide already converted model and model_index.json contains safety_checker object definition, pipeline loading failed in attempt to load model for it:
OSError: Error no file named pytorch_model.bin, model.safetensors, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova changed the title add saving safety_checker during conversion add saving safety_checker Nov 7, 2024
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

optimum/exporters/openvino/convert.py Show resolved Hide resolved
@AlexKoff88 AlexKoff88 merged commit 790244d into huggingface:main Nov 12, 2024
21 of 24 checks passed
@eaidova eaidova deleted the ea/safety_checker_save branch November 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants