-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize memory when loading checkpoint #246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NouamaneTazi
force-pushed
the
nouamane/optim-state-cpu-offload
branch
from
November 21, 2024 16:15
7299fdc
to
bc25a35
Compare
xrsrke
reviewed
Nov 22, 2024
xrsrke
reviewed
Nov 22, 2024
xrsrke
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a small comment.
xrsrke
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offload memory states to CPU to avoid memory peak when loading checkpoint, and only move to GPU after first fwd-bwd
Details
It seems that the peak reserved memory is higher when we load a checkpoint because when we do the 1st fwd-bwd, which is the most heavy in terms of memory allocation, we already have the optimizer’s state loaded.
Whereas when we train from scratch we do fwd-bwd (optimizer’s state doesnt load yet), then free some memory, then reallocate the optimizer’s state
TLDR; The memory demand when loading a checkpoint is larger by Optimizer’s state compared when training from scratch