-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencies upper bounds constraints #145
Conversation
…_07_remove_upper_bounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simon. One comment.
pyproject.toml
Outdated
h5py = "^3.10.0" | ||
huggingface-hub = "^0.21.4" | ||
opencv-python = ">=4.9.0" | ||
diffusers = ">=0.27.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only diffusion policy relies on diffusers and I'd like to remove this reliance so that we don't get bitten by b/c changes. Can we keep this version constraint tight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: cc087ea
dc330f8
to
cc087ea
Compare
…_07_remove_upper_bounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
What this does
Remove upper bounds contraints on most dependencies (except torch and mujoco).
Related:
How it was tested
Using the regular testing suite
Additionally, did a build/test cycle to make sure everything runs ok: https://github.com/huggingface/lerobot/actions/runs/9001567510