Add debug script to check inference snippets + update Python text-to-image snippets #994
Conversation
Wauplin
requested review from
SBrandeis,
gary149,
julien-c and
pcuenca
as code owners
Co-authored-by: Julien Chaumond <[email protected]>
Co-authored-by: Julien Chaumond <[email protected]>
| }); | ||
| }, | ||
| { | ||
| client: "huggingface_hub", |
There was a problem hiding this comment.
maybe let's agree on the convention of putting huggingface_hub as the first item in the list
| @@ -0,0 +1,55 @@ | |||
| /* | |||
There was a problem hiding this comment.
I've implemented tests in https://github.com/huggingface/huggingface.js/pull/1003/files using the vite test convention of xyz.spec.ts files (which run on pnpm test).
I think we should just put more tests into xyz.spec.ts files rather than creating a custom mechanism of check-snippet.ts & inference-check-snippets.yml. Or am I missing some necessary details?
Wdyt?
There was a problem hiding this comment.
I went with this solution because I was bored about how difficult it was to debug things locally but automated tests feel much more natural now that you mention it ^^
|
closing in favor of #1016 |
Supersedes #994. This PR adds an `huggingface_hub` snippet for `text-to-image` inference in Python. I added a test as done in #1003. Once this one is approved and merged, I'll move on with all other tasks that the `InferenceClient` supports. --------- Co-authored-by: Mishig <[email protected]>
Reviewing PRs that updates the inference snippets is a bit painful / error-prone given that we can't easily check the diff.
This PR tries to solve this a bit with a new command that prints the inference snippets to the terminal. I also (tried) to add an automated check in the CI to avoid figuring it out manually. Let's see if it proves useful.
I also started to update the Python inference snippets, starting with the
text-to-imageone to return bothrequestsandhuggingface_hubversions.Note: the update of=> removed the dependency in b3deb60 (no real need for it)packages/tasks/pnpm-lock.yamlis far too much. I'll check if I can't minimize it (I only needed to add a dev dependency).Snippets can be checked in https://github.com/huggingface/huggingface.js/actions/runs/11579670253/job/32236421855?pr=994.