Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DepthPro library #961

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Add DepthPro library #961

merged 5 commits into from
Oct 9, 2024

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Oct 8, 2024

No description provided.

@pcuenca
Copy link
Member Author

pcuenca commented Oct 8, 2024

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and thanks for opening this! Just had a small doubt regarding the PIL import.

packages/tasks/src/model-libraries-snippets.ts Outdated Show resolved Hide resolved
pip install huggingface-hub
huggingface-cli download --local-dir checkpoints ${model.id}`;

const inferenceSnippet = `import depth_pro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make the snippet more minimal given there are instructions on the model card

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have been trying to make snippets end-to-end - I think having a more complete snippet here would be better (even if it mimics the model card)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @Vaibhavs10, lately I've seen PRs with more complete snippets and I like them (and there's enough space to show a standalone example).

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcuenca !

Comment on lines 169 to 170
prettyLabel: "DepthPro",
repoName: "Depth Pro",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A particular reason why having DepthPro and Depth Pro?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, when reviewing these PRs I always wonder if we should keep only 1 field given how similar they are

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official name seems to be "Depth Pro", as that's what appears in the GitHub repo. I used DepthPro for the label because in most other cases (but not all) we use single words. Happy to change to Depth Pro!

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI errors look unrelated!

@pcuenca pcuenca merged commit e201d55 into huggingface:main Oct 9, 2024
2 of 4 checks passed
@pcuenca pcuenca deleted the depth-pro-library branch October 9, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants