-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DepthPro library #961
Add DepthPro library #961
Conversation
cc @NielsRogge @Vaibhavs10 @Amael Corresponding Hub PR: https://huggingface.co/apple/DepthPro/discussions/6/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and thanks for opening this! Just had a small doubt regarding the PIL
import.
pip install huggingface-hub | ||
huggingface-cli download --local-dir checkpoints ${model.id}`; | ||
|
||
const inferenceSnippet = `import depth_pro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should make the snippet more minimal given there are instructions on the model card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have been trying to make snippets end-to-end - I think having a more complete snippet here would be better (even if it mimics the model card)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @Vaibhavs10, lately I've seen PRs with more complete snippets and I like them (and there's enough space to show a standalone example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pcuenca !
prettyLabel: "DepthPro", | ||
repoName: "Depth Pro", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A particular reason why having DepthPro
and Depth Pro
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, when reviewing these PRs I always wonder if we should keep only 1 field given how similar they are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The official name seems to be "Depth Pro", as that's what appears in the GitHub repo. I used DepthPro
for the label because in most other cases (but not all) we use single words. Happy to change to Depth Pro
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI errors look unrelated!
No description provided.