Standardize HF_ACCESS_TOKEN -> HF_TOKEN #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
nsarrazin,
osanseviero,
merveenoyan,
pcuenca,
vvmnnnkv and
radames
as code owners
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
coyotte508
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thanks!
I don't think we need to migrate HF_TOKEN actually, it's not used in inference due to flakiness, hub uses a mirror of the hub to do tests and agents tests still seem to work cc @nsarrazin
(Will migrate in the future if needed)
|
Ok good to know for the github secret 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as xenova/transformers.js#431.
Related to slack thread (internal).
This PR standardizes the name of the environment variable used to make requests with a HF API token. The goal is to harmonize it across the HF ecosystem. For what I've seen,
HF_ACCESS_TOKENwas not an "official" environment variable but simply the one used in docs and tests. Updating the naming should not break anything in the libraries.TODO before merging update
HF_ACCESS_TOKENtoHF_TOKENin Github repo secrets.cc @xenova @julien-c