⬆️ upgrade vitest, @vitest/browser #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 🤯 |
coyotte508
approved these changes
Nov 26, 2023
coyotte508
reviewed
Nov 26, 2023
|
If the demo app of |
@coyotte508, it does! :-) |
|
Sure! (if you can solve the TS problem, otherwise let's do it in another PR :) ) |
vvmnnnkv
requested review from
nsarrazin,
mishig25,
osanseviero,
merveenoyan,
pcuenca and
radames
as code owners
|
Back to vite 4 for widgets, there's no official vite 5 support in sveltekit yet |
coyotte508
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
inference package used to substitute "process.env" with
process.envcontents invitest.config.ts(usingdefine), this is broken in more recent version of vitest: vitest-dev/vitest#3900.So the solution is to use
import.meta.env. But since it passes through only vars with "VITE_" prefix,envPrefixis needed include vars starting withHF_andVCR_.Additionally, moved
expect.closeTo()to a separate file, it can be removed with update to vitest 1.0.