Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit2 - train #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fardinafdideh
Copy link
Contributor

  • I added (and commented) the following formula for epsilon calculation which as opposed to the current formula is dependent on the "n_training_episodes" (the two formulas output for some "n_training_episodes" has been shown in the figure), hence regardless of the "n_training_episodes" the epsilon value decays exponentially over the whole range of steps from "max_epsilon" to "min_epsilon":
    epsilon = max_epsilon * ((min_epsilon/max_epsilon)**(1/(n_training_episodes-1))) ** episode
    epsilon_exponentialDecay

  • The following lines in the "train" function were removed. "step" variable is unused. The variables "terminated" and "truncated" are evaluated as the output of "env.step(action)" before their first use, so there is no need to be initialized.

    • step = 0
    • terminated = False
    • truncated = False
  • The "for" loop counter, "step", and also "info" were replaced with "_", because they are unused.

@simoninithomas
Copy link
Member

Thanks for pointing this out I’m adding this for the december update

@simoninithomas simoninithomas mentioned this pull request Dec 12, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants