Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let server decide default repo visibility #7302

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 28, 2024

Until now, all repos were public by default when created without passing the private argument. This meant that passing private=False or private=None was strictly the same. This is not the case anymore. Enterprise Hub offers organizations to set a default visibility setting for new repos. This is useful for organizations forbidding public repos for security matters. This PR mostly updates docstrings + default values so that private=None is always passed when users don't set it manually.

This PR doesn't create any breaking change. The real update has been done server-side when introducing the new Enterprise Hub feature. Related to huggingface/huggingface_hub#2679.

@Wauplin Wauplin requested a review from lhoestq November 28, 2024 16:01
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! does it require a minimum version of huggingface_hub ?

feel free to merge after make style (use latest ruff and python>=3.9)

@Wauplin
Copy link
Contributor Author

Wauplin commented Nov 29, 2024

No need for a specific version of huggingface_hub to avoid a breaking change no (it's a server-side change)

@Wauplin Wauplin merged commit c8252f2 into main Nov 29, 2024
7 of 15 checks passed
@Wauplin Wauplin deleted the respect-repo-visibility branch November 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants