Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets to 2.21.0 #3037

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Update datasets to 2.21.0 #3037

merged 9 commits into from
Sep 26, 2024

Conversation

albertvillanova
Copy link
Member

Update datasets to 2.21.0.

Fix #3024.

@albertvillanova
Copy link
Member Author

The are errors in the CI tests.

I guess at least some of them are related to the change in the Hub in relation with gated datasets:

I am updating huggingface-hub.

@albertvillanova
Copy link
Member Author

I have decided to update first to datasets-2.20.0 and check all CI tests pass:

Afterwards, we can merge main to this PR and see the CI tests: if there is a bug in datasets-2.21.0, we could make a patch release and update to datasets-2.21.1 instead.

@albertvillanova
Copy link
Member Author

I am resolving the conflicts of this PR.

I think we could merge it and then I could update to dataset 3.0 and see if something new is broken...

@albertvillanova
Copy link
Member Author

The current failing test is unrelated:

ERROR tests/job_runners/split/test_descriptive_statistics.py::test_polars_struct_thread_panic_error - huggingface_hub.utils._errors.RepositoryNotFoundError: 404 Client Error. (Request ID: Root=1-66f560ea-0d3bd15934a45d7838ac6bb3;f1b1e4ce-2768-4f41-a5d8-f1c1c129addc)

Repository Not Found for url: https://hub-ci.huggingface.co/datasets/__DUMMY_TRANSFORMERS_USER__/test_polars_panic_error/resolve/main/test_polars_panic_error.parquet.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.

See:

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok !

@albertvillanova albertvillanova merged commit c10ccac into main Sep 26, 2024
26 of 27 checks passed
@albertvillanova albertvillanova deleted the fix-3024 branch September 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to [email protected]
2 participants