-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 update the OpenAPI spec #1667
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
+ Coverage 90.35% 90.38% +0.03%
==========================================
Files 204 208 +4
Lines 12636 12744 +108
==========================================
+ Hits 11417 11519 +102
- Misses 1219 1225 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The documentation is not available anymore as the PR was closed or merged. |
72a15d9
to
2c83386
Compare
also fix some types
here: the error is on the server, so: changing it to 500. by the way, we don't have any error of this kind in the cache, which is good since it would reveal a bug in the code.
alsways give a URL
@@ -136,7 +147,10 @@ class ConfigSize(TypedDict): | |||
num_columns: int | |||
|
|||
|
|||
class SplitSize(SplitItem): | |||
class SplitSize(TypedDict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to FullSplitItem instead of TypedDict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it could be. But I found that a lot of indirections are not easy to follow. Easier to just put the four properties
Missing:
400 (BAD_REQUEST)(removed 400 from the code with d4ee7a5), 501 (NOT_IMPLEMENTED)with spectral-> check that the openapi specification is valid #446In other PRs:
document all the X-Error-Code in OpenAPI -> Document all the X-Error-Code in OpenAPI #1671
do contract testing on the OpenAPI examples. Maybe use a new field, like
x-contract-testing-url
, to get the URL to test programmatically. Also: create permanent test datasets (like severo/private) in prod that can be used to contract test in prod? -> Add tests to do proper contract testing #518generate OpenAPI spec from the code -> Generate OpenAPI specification from the code #1670
test authenticated against authorized, and maybe add examples in the openapi spec -> in Gated datasets without authentication header return 404 #1656