remove locks when finishing a job #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also: add the description in readme, and fix test value
ArgoCD Diff for commit
|
| Legend | Status |
|---|---|
| ✅ | The app is synced in ArgoCD, and diffs you see are solely from this PR. |
| The app is out-of-sync in ArgoCD, and the diffs you see include those changes plus any from this PR. | |
| 🛑 | There was an error generating the ArgoCD diffs due to changes in this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 99.37% 92.24% -7.14%
==========================================
Files 6 77 +71
Lines 161 5464 +5303
==========================================
+ Hits 160 5040 +4880
- Misses 1 424 +423
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
should fix the issue with old remaining locks, when a job is killed (too long job, after 40 minutes) while it's uploading files to the Hub (lock created with git_branch()).
severo
changed the title
|
research notes: to get all the old remaining locks: Today: returns 64 entries, eg: They have a non-null owner, and have been created with lock.git_branch() (ie: during parquet or duckdb index upload). Possibly: when a pod was killed (sync? zombie killer?)
|
|
I'll manually remove the owner from the existing old lock entries after deploying with: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix the issue with old remaining locks, when a job is killed (too long job, after 40 minutes) while it's uploading files to the Hub (lock created with git_branch()).
also: add environment variables in docker compose and helm, add the description in readme, and fix test value