-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datasets dependency to 2.14.2 version #1588
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
- Coverage 91.15% 89.17% -1.98%
==========================================
Files 141 123 -18
Lines 10318 6900 -3418
==========================================
- Hits 9405 6153 -3252
+ Misses 913 747 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the CI error does not seem to be related, but maybe @AndreaFrancis can give a better opinion, since it's related to spawning.io
For the woker unit-tests, it looks like other tests are failing test_parquet_and_info, test_split_names_from_streaming, test_config_names, test_descriptive_statistics, test_duckdb_index, test_first_rows_from_streaming, etc.
Maybe is something related to the new default config? |
Thanks a lot, @AndreaFrancis for your insights! I had missed those specific errors. I think more fixes are needed in the |
we can close this PR, right? |
Superseded by: |
Update
datasets
dependency to version 2.14.2, instead of 2.14.1 because there were issues. See:Fix #1589.
Fix partially #1550.
Supersede and close #1577.