Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets dependency to 2.14.2 version #1588

Closed
wants to merge 2 commits into from

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jul 31, 2023

Update datasets dependency to version 2.14.2, instead of 2.14.1 because there were issues. See:

Fix #1589.
Fix partially #1550.

Supersede and close #1577.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -1.98% ⚠️

Comparison is base (e792862) 91.15% compared to head (f92ea34) 89.17%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   91.15%   89.17%   -1.98%     
==========================================
  Files         141      123      -18     
  Lines       10318     6900    -3418     
==========================================
- Hits         9405     6153    -3252     
+ Misses        913      747     -166     
Flag Coverage Δ
jobs_cache_maintenance 99.08% <ø> (ø)
jobs_mongodb_migration 85.07% <ø> (?)
libs_libapi 92.81% <ø> (?)
libs_libcommon 91.53% <ø> (ø)
services_admin 85.87% <ø> (ø)
services_api 88.06% <100.00%> (?)
services_rows 83.55% <75.00%> (+0.09%) ⬆️
services_worker ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
services/rows/src/rows/routes/rows.py 61.70% <0.00%> (ø)
services/api/src/api/routes/endpoint.py 78.33% <100.00%> (ø)
services/rows/tests/routes/test_rows.py 92.97% <100.00%> (+0.11%) ⬆️

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertvillanova albertvillanova changed the title Update datasets 2.14.2 Update datasets dependency to 2.14.2 version Jul 31, 2023
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the CI error does not seem to be related, but maybe @AndreaFrancis can give a better opinion, since it's related to spawning.io

@AndreaFrancis
Copy link
Contributor

For the woker unit-tests, it looks like other tests are failing test_parquet_and_info, test_split_names_from_streaming, test_config_names, test_descriptive_statistics, test_duckdb_index, test_first_rows_from_streaming, etc.
Looks like there are some problems like:

  • Forbidden error to write to refs/convert/parquet
  • ValueError: BuilderConfig '...' not found. Available: ['default']
  • libcommon.exceptions.FileSystemError: Could not read the parquet files: get_authentication_headers_for_url() got an unexpected keyword argument 'use_auth_token'

Maybe is something related to the new default config?

@albertvillanova
Copy link
Member Author

Thanks a lot, @AndreaFrancis for your insights! I had missed those specific errors.

I think more fixes are needed in the datasets library to address all these backward incompatibility issues. I am addressing them and will do a new patch release.

@severo
Copy link
Collaborator

severo commented Aug 4, 2023

we can close this PR, right?

@albertvillanova
Copy link
Member Author

Superseded by:

@albertvillanova albertvillanova deleted the update-datasets-2.14.2 branch January 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update datasets dependency to 2.14
4 participants