[Draft]: Add flash attention to whisper (unsure how correct this is) #2722
+75
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murad-Awad
commented
Jan 16, 2025
| let k = k.transpose(1, 2)?; | ||
| let v = v.transpose(1, 2)?; | ||
| let softmax_scale = 1f32 / (self.n_head as f32).sqrt(); | ||
| flash_attn(&q, &k, &v, softmax_scale, true)?.transpose(1, 2) |
There was a problem hiding this comment.
I think all attention is technically causal in whisper given that it predicts tokens sequentially. I could be wrong on this though and I have a very cursory understanding of flash attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whisper should be able to support flash attention. I attempted to add this in this PR; I don't know much about flash attention and a lot of this was pattern matching with other examples in the repo. I need to take a more detailed look later.