fix to_scalar issue of very high latency #2240
Open
+69
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to resolve this issue.
Since the dimension of the tensor you wish to call to_scalar is 0.
So I changed the match arm of
CudaStorage
into_scalar
by directly callingdtoh_sync_copy
on aCudaView<T>
created designated for copy to CPU mem.Calling
dtoh_sync_copy
directly withCudaSlice<T>
will cause a full copy on the underlying storage. By calling CudaView will resolve this problem.Code sample.
Fix #2239