Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ThirdAI Library #425

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dtr3
Copy link

@dtr3 dtr3 commented May 28, 2024

Hello!

Overview

Looking to integrate the ThirdAI library for text and token classification

Details

ThirdAI is a model framework with native support for LSH sparse computations. Right now there are only a couple of models on huggingface but hope to have more in the future.

To the best of my knowledge I've followed the instructions in the README as well as this example thread for Setfit as a very helpful reference. Please let me know if there's anything else I should do from this point.

Questions

I am having trouble running tests locally (for all libraries) with the following errors:

For the malformed question tests:
AssertionError: b'{"error":"404 Client Error. (Request ID: Root=1-665[174 chars]n."}' != b'{"error":"\'utf-8\' codec can\'t decode byte 0xc3 i[37 chars]te"}'

For the simple tests:

with TestClient(self.app) as client:
            response = client.post("/", json={"inputs": inputs})
>       self.assertEqual(
            response.status_code,
            200,
        )
E       AssertionError: 400 != 200

This is my first contribution so perhaps there is something obvious I am missing in the test setup maybe someone can point me in the right direction.

Related PR: huggingface/huggingface.js#689

Thanks so much!
-David

@dtr3
Copy link
Author

dtr3 commented Jun 5, 2024

@osanseviero @Narsil Hello, sorry to bother you, would either of you know someone who might be able to take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants