-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate DeepSpeed's new HF interface for sequence parallelism #3299
Open
ronald-d-rogers
wants to merge
14
commits into
huggingface:main
Choose a base branch
from
ronald-d-rogers:ds-ulysses
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
cc @XuehaiPan |
5 tasks
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds changes to support DeepSpeed's updated mesh device interface for sequence parallel training, introduced here:
microsoft/DeepSpeed#5774
It adds flags to
DeepSpeedPlugin
andHFDeepSpeedConfig
which can be used intranformers
to determine the state of sequence parallelism.Note that in sequence parallel the inputs must be sharded such that only the each rank in the sequence parallel groups gets only its shard of the sequence.
If you look at the commit history, you will see that I toyed with doing this in
accelerate
itself, but ultimately determined that the sharding must be done in the trainers, right before the call themodel(**inputs)
, otherwise libraries with custom trainers (i.e. `trl) would have to refactor the way their trainers prepare data.Currently, this must be merged before the corresponding
ds-ulysses
PR intranformers
is merged.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.