Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] remove autodocs tag #264

Merged
merged 13 commits into from
Jun 21, 2024
Merged

[DOCS] remove autodocs tag #264

merged 13 commits into from
Jun 21, 2024

Conversation

seongminn
Copy link
Member

🌍 이슈 번호

βœ… μž‘μ—… λ‚΄μš©

  • λͺ¨λ“  μŠ€ν† λ¦¬λΆ 파일의 autodocs 생성 νƒœκ·Έλ₯Ό μ œκ±°ν•©λ‹ˆλ‹€.
  • μƒνƒœ 등을 κ³΅μœ ν•˜λŠ” κ²½μš°κ°€ λ°œμƒν•˜μ—¬ 각 μŠ€ν† λ¦¬λ₯Ό κ°œλ³„μ μœΌλ‘œ ν…ŒμŠ€νŠΈ ν•˜λŠ” 것을 λ°©ν•΄ν•˜λŠ” 것 κ°™λ‹€κ³  νŒλ‹¨ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“ μ°Έκ³  자료

♾️ 기타

@seongminn seongminn added the DOCS λ¬Έμ„œ μˆ˜μ • label Jun 14, 2024
@seongminn seongminn requested a review from ohprettyhak June 14, 2024 10:21
@seongminn seongminn self-assigned this Jun 14, 2024
@seongminn seongminn changed the base branch from main to feat/ui-form-elements June 14, 2024 10:21
Copy link
Member

@ohprettyhak ohprettyhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. src/styles 뢀뢄은 κΈ°μ‘΄ νŒ¨ν‚€μ§€μ— μž‘μ„±λ˜μ–΄ 있던 μŠ€νƒ€μΌμ΄ μž‘λ™μ„ μ•ˆ ν•΄μ„œ μΆ”κ°€λ‘œ λ„£μ–΄μ£Όμ‹  κ±΄κ°€μš”?

@seongminn
Copy link
Member Author

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. src/styles 뢀뢄은 κΈ°μ‘΄ νŒ¨ν‚€μ§€μ— μž‘μ„±λ˜μ–΄ 있던 μŠ€νƒ€μΌμ΄ μž‘λ™μ„ μ•ˆ ν•΄μ„œ μΆ”κ°€λ‘œ λ„£μ–΄μ£Όμ‹  κ±΄κ°€μš”?

μ •ν™•ν•œ 이유λ₯Ό ν™•μΈν•˜μ§€λŠ” λͺ»ν–ˆλŠ”데 배포λ₯Ό ν•˜κ³  λ‚˜λ©΄ @hcc/styles에 ν¬ν•¨λœ κΈ€λ‘œλ²Œ μŠ€νƒ€μΌμ΄ μŠ€ν† λ¦¬λΆμ— μ μš©λ˜μ§€κ°€ μ•Šλ˜ 버그가 μžˆμ—ˆμŠ΅λ‹ˆλ‹€. κ·Έλž˜μ„œ μŠ€ν† λ¦¬λΆμ—μ„œ λ”°λ‘œ κΈ€λ‘œλ²Œ μŠ€νƒ€μΌμ„ 생성해주고, 이λ₯Ό μ μš©ν•΄μ€€ λΆ€λΆ„μž…λ‹ˆλ‹€!

Copy link
Member

@ohprettyhak ohprettyhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기쑴에 styled-componentsλ₯Ό μ‚¬μš©ν•œ ν”„λ‘œμ νŠΈμ—μ„œλŠ” @hcc/styles와 같이 κ°€μ Έμ˜¨ 적이 μžˆλŠ”λ°, μ—¬κΈ°μ„œλŠ” 무언가 λ„˜μ–΄κ°€μ§€κ°€ μ•ŠλŠ”κ°€ λ³΄κ΅°μš”. ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

@seongminn
Copy link
Member Author

기쑴에 styled-componentsλ₯Ό μ‚¬μš©ν•œ ν”„λ‘œμ νŠΈμ—μ„œλŠ” @hcc/styles와 같이 κ°€μ Έμ˜¨ 적이 μžˆλŠ”λ°, μ—¬κΈ°μ„œλŠ” 무언가 λ„˜μ–΄κ°€μ§€κ°€ μ•ŠλŠ”κ°€ λ³΄κ΅°μš”. ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

vanilla extract의 μŠ€νƒ€μΌ 생성 방식에 μ˜ν•œ 차이인 것 κ°™μ•„μš”. .css.ts ν™•μž₯자 파일의 λ‚΄λΆ€μ—μ„œλ§Œ μŠ€νƒ€μΌμ„ 생성해쀄 수 있고 자체적으둜 μ œμ•½μ΄ λ§Žμ€ 것 κ°™μŠ΅λ‹ˆλ‹€.. κ΄€λ ¨ν•΄μ„œ @hcc/ui νŒ¨ν‚€μ§€μ˜ μ»΄ν¬λ„ŒνŠΈκ°€ νŠΈλ¦¬μ‰μ΄ν‚Ήμ΄ λ˜μ§€ μ•Šκ³  μžˆμ–΄μ„œ rollupμ΄λ‚˜ tsup으둜 κ΅¬μ„±ν•˜λ € μ‹œλ„ν•΄λ³΄μ•˜λŠ”λ°, λ§ˆμ°¬κ°€μ§€λ‘œ vanilla-extract의 μŠ€νƒ€μΌ 생성 μ‹œμ  λ“±κ³Ό κ΄€λ ¨ν•΄μ„œ λ¬Έμ œκ°€ λ°œμƒν•˜μ—¬ μ œλŒ€λ‘œ μŠ€νƒ€μΌ 적용이 λ˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

μ•„λ¬΄νŠΌ ν•΄λ‹Ή PR은 일단 λ³‘ν•©ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€! λ‚˜μ€‘μ— λŒ€μ•ˆμ„ λ§ˆλ ¨ν•΄μ„œ μˆ˜μ •ν•˜λ©΄ 쒋을 것 κ°™μ•„μš”!

@ohprettyhak
Copy link
Member

기쑴에 styled-componentsλ₯Ό μ‚¬μš©ν•œ ν”„λ‘œμ νŠΈμ—μ„œλŠ” @hcc/styles와 같이 κ°€μ Έμ˜¨ 적이 μžˆλŠ”λ°, μ—¬κΈ°μ„œλŠ” 무언가 λ„˜μ–΄κ°€μ§€κ°€ μ•ŠλŠ”κ°€ λ³΄κ΅°μš”. ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

vanilla extract의 μŠ€νƒ€μΌ 생성 방식에 μ˜ν•œ 차이인 것 κ°™μ•„μš”. .css.ts ν™•μž₯자 파일의 λ‚΄λΆ€μ—μ„œλ§Œ μŠ€νƒ€μΌμ„ 생성해쀄 수 있고 자체적으둜 μ œμ•½μ΄ λ§Žμ€ 것 κ°™μŠ΅λ‹ˆλ‹€.. κ΄€λ ¨ν•΄μ„œ @hcc/ui νŒ¨ν‚€μ§€μ˜ μ»΄ν¬λ„ŒνŠΈκ°€ νŠΈλ¦¬μ‰μ΄ν‚Ήμ΄ λ˜μ§€ μ•Šκ³  μžˆμ–΄μ„œ rollupμ΄λ‚˜ tsup으둜 κ΅¬μ„±ν•˜λ € μ‹œλ„ν•΄λ³΄μ•˜λŠ”λ°, λ§ˆμ°¬κ°€μ§€λ‘œ vanilla-extract의 μŠ€νƒ€μΌ 생성 μ‹œμ  λ“±κ³Ό κ΄€λ ¨ν•΄μ„œ λ¬Έμ œκ°€ λ°œμƒν•˜μ—¬ μ œλŒ€λ‘œ μŠ€νƒ€μΌ 적용이 λ˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

μ•„λ¬΄νŠΌ ν•΄λ‹Ή PR은 일단 λ³‘ν•©ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€! λ‚˜μ€‘μ— λŒ€μ•ˆμ„ λ§ˆλ ¨ν•΄μ„œ μˆ˜μ •ν•˜λ©΄ 쒋을 것 κ°™μ•„μš”!

λ„΅ μ•Œκ² μŠ΅λ‹ˆλ‹€. πŸ‘

Base automatically changed from feat/ui-form-elements to main June 21, 2024 12:44
@seongminn seongminn merged commit 539a754 into main Jun 21, 2024
@seongminn seongminn deleted the docs/storybook-docs branch June 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOCS λ¬Έμ„œ μˆ˜μ •
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] remove autodocs tag
2 participants