Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angularjs 1.4.7 support #137

Closed
hueitan opened this issue Aug 30, 2015 · 15 comments
Closed

angularjs 1.4.7 support #137

hueitan opened this issue Aug 30, 2015 · 15 comments

Comments

@hueitan
Copy link
Owner

hueitan commented Aug 30, 2015

Need contribution.

@lvarayut
Copy link
Collaborator

lvarayut commented Oct 6, 2015

Could you list all features that you wish to develop? I could pick up some of them.

@lvarayut
Copy link
Collaborator

This is the list of enhancements:

Priority Subject Assignee Progress
High Support checkbox and radio button (#40) @lvarayut
High Fix multidir error when using with another directive (#95 and #113) @Nazanin1369 DONE #
High Support AngularJs 1.4.x (#137) @Nazanin1369 DONE #
High Definition for showSuccessMessage/showErrorMessage and no-validation-message @huei90 DONE #
Medium Improve the HTML documentation: Move API.md and Q&A.md to their own HTML pages, Organize the documentation to be more beautiful @Nazanin1369 DONE #
Medium Support i18n Pending ...
Medium Support ng-repeat in angular-validation version 1.2.x #139 Pending ...
Low Make a logo and put it into the README.md Pending ...
Low Rewrite everything in ES6 or Typescript (Optional) Pending ...
Low Prepare for upcoming AngularJs 2.0 Pending ...
Low Support gulp or npm run Pending ...

@hueitan
Copy link
Owner Author

hueitan commented Nov 3, 2015

New issue.
Support ng-repeat in angular-validation version 1.2.x
#139

@hueitan
Copy link
Owner Author

hueitan commented Nov 11, 2015

Refactor new documentation. It is not easy to read now.
Update feature list.

@kmckee
Copy link

kmckee commented Nov 13, 2015

Has anyone tried using this library with Angular 1.4?

We are looking to migrate next week. I was just about to pull this library in to our app, but I don't want to if it will be broken when we move to 1.4.

@hueitan
Copy link
Owner Author

hueitan commented Nov 13, 2015

Hi @kmckee Thanks for dropping us a message.

Unfortunately, the test result running on angular 1.4 in current validation version is fail.

We are still trying hard to move the support version to the latest one. Please stay tuned.

@lvarayut @Nazanin1369 seems we have lot of works to do now 🍻

@kmckee
Copy link

kmckee commented Nov 13, 2015

Thanks for the quick reply @huei90. I might peek under the covers if I get some time and see if I can help out. Very cool library, it cleaned up a lot of boring boiler plate code from our codebase.

@hueitan
Copy link
Owner Author

hueitan commented Nov 14, 2015

it cleaned up a lot of boring boiler plate code from our codebase.

Yes, this is the main purpose why I'm building angular-validation 👍

@edriang
Copy link

edriang commented Dec 2, 2015

I have the following questions in order to decide to use or not this great module:

  • Wich are the problems with Angular 1.4?
  • It is possible to integrate i18n messages with angular-translate module?

Thanks in advance

@hueitan
Copy link
Owner Author

hueitan commented Dec 3, 2015

Hi @edriang
First, we are not yet fully support angular 1.4
Secondly, for the i18n, see if this works to you and I can help you on that. #96

@hueitan
Copy link
Owner Author

hueitan commented Dec 14, 2015

OMG.. angular 1.5 is coming. 🔥

Nazanin1369 added a commit that referenced this issue Dec 17, 2015
@hueitan
Copy link
Owner Author

hueitan commented Dec 17, 2015

@kmckee @edriang Sorry for the late replied. v1.4.x is now ready! 💥

you can use it now. remember change the branch to v1.4.x

@Nazanin1369 Nazanin1369 changed the title angularjs1.3.0 & 1.4.0 support angularjs 1.4.7 support Dec 17, 2015
@Nazanin1369
Copy link
Collaborator

Congrats! Tests passed with Angular1.4.x.
Change confirmed. closing this issue.

@lvarayut Can you move the enhancement list out of this issue?

@hueitan
Copy link
Owner Author

hueitan commented Dec 17, 2015

🍻

@hueitan
Copy link
Owner Author

hueitan commented Dec 17, 2015

I have change the title to Ticket and Enhancement #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants