Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grunt support, change to npm run. #169

Closed
hueitan opened this issue Dec 14, 2015 · 12 comments
Closed

Remove Grunt support, change to npm run. #169

hueitan opened this issue Dec 14, 2015 · 12 comments

Comments

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

What do you see. @Nazanin1369 @lvarayut

@Nazanin1369
Copy link
Collaborator

Totally agree. I can go ahead and change that...
On Dec 13, 2015 10:49 PM, "Huei Tan" [email protected] wrote:

What do you see. @Nazanin1369 https://github.com/Nazanin1369 @lvarayut
https://github.com/lvarayut


Reply to this email directly or view it on GitHub
#169.

@hueitan
Copy link
Owner Author

hueitan commented Dec 14, 2015

Thank you @Nazanin1369 We can have the discussions here.

@lvarayut
Copy link
Collaborator

@huei90, if we deleted it, would it be still possible to do liverealod, concat, combine, test, and etc?

@hueitan
Copy link
Owner Author

hueitan commented Dec 14, 2015

@lvarayut I have never tried this before, but npm is possible to do the tasks.

read

http://blog.keithcirkel.co.uk/how-to-use-npm-as-a-build-tool/

@lvarayut
Copy link
Collaborator

The only disadvantage is that we can't put any comments inside JSON file; package.json. If the project was getting bigger, it would be more difficult to manage the file.

@hueitan
Copy link
Owner Author

hueitan commented Dec 14, 2015

we can't put any comments inside JSON file;

yes, this is the cons we should concern about, using grunt or gulp are the easier tools to use.

using npm will looks like this

"scripts": {
    "build": "ecmarkup --js=spec.js --css=spec.css spec.emu | js-beautify -f - --type=html -t > index.html",
}

Edit, here I think we can make it

  1. make npm run [name] readable and understandable
  2. make comment in CONTRIBUTING.md if we really need it

@Nazanin1369
Copy link
Collaborator

I think one thing to consider is the flexibility of the tasks which I think using "Gulp" is the best.
Gulp pipes makes writing the tasks more readable and easier.

I am not agree with Grunt at all.

What do u think about Gulp?

https://ponyfoo.com/articles/choose-grunt-gulp-or-npm

@lvarayut
Copy link
Collaborator

I prefer gulp more than other. It's much faster than grunt and more
flexible than package.json.

On Tuesday, December 15, 2015, Nazanin Delam [email protected]
wrote:

I think one thing to consider is the flexibility of the tasks which I
think using "Gulp" is the best.
Gulp pipes makes writing the tasks more readable and easier.

I am not agree with Grunt at all.

What do u think about Gulp?

https://ponyfoo.com/articles/choose-grunt-gulp-or-npm


Reply to this email directly or view it on GitHub
#169 (comment)
.

@Nazanin1369
Copy link
Collaborator

Yes! Agree, then let's move toward gulp is Huei agree too.
On Dec 14, 2015 5:43 PM, "Varayut Lerdkanlayanawat" <
[email protected]> wrote:

I prefer gulp more than other. It's much faster than grunt and more
flexible than package.json.

On Tuesday, December 15, 2015, Nazanin Delam [email protected]
wrote:

I think one thing to consider is the flexibility of the tasks which I
think using "Gulp" is the best.
Gulp pipes makes writing the tasks more readable and easier.

I am not agree with Grunt at all.

What do u think about Gulp?

https://ponyfoo.com/articles/choose-grunt-gulp-or-npm


Reply to this email directly or view it on GitHub
<
#169 (comment)

.


Reply to this email directly or view it on GitHub
#169 (comment)
.

@hueitan
Copy link
Owner Author

hueitan commented Dec 15, 2015

grunt or gulp look same to me, we are not a big project so the speed is not the matter.

In this topic, I am considering about npm for the management, less code in the project.

now, I saw the benefit from npm run

we don't really need both grunt and gulp because npm can do the exactly same task. Dealing with the cons, we can write more on the CONTRIBUTING.md

OR, we can continue to focus on the feature development. we have a great improvement recently, thanks to @Nazanin1369 isolate scope feature, @lvarayut validation-group feature, these are the good processes and results from the team.

Let's leave the issue here, maybe we can have more discussions.

@kcliu - what do you see.
#107

@Nazanin1369
Copy link
Collaborator

I think this is a low priority enhancement. We can make it unless there is
no reported issue or higher priority enhancement ticket available.
On Dec 14, 2015 6:47 PM, "Huei Tan" [email protected] wrote:

grunt or gulp look same to me, we are not a big project so the speed is
not the matter.

In this topic, I am considering about npm for the management, less code
in the project.

now, Ii see the benefit from npm run

we don't really need both grunt and gulp because npm can do the exactly
same task. Dealing with the cons, we can write more on the CONTRIBUTING.md

OR, we can continue to focus on the feature development. we have a great
improvement recently, thanks to @Nazanin1369
https://github.com/Nazanin1369 isolate scope feature, @lvarayut
https://github.com/lvarayut validation-group feature, these are the
good processes and results from the team.

Let's leave the issue here, maybe we can have more discussions here.

@kcliu https://github.com/kcliu - what do you see.
#107 #107


Reply to this email directly or view it on GitHub
#169 (comment)
.

@hueitan
Copy link
Owner Author

hueitan commented Dec 15, 2015

I have added this as the low priority.
#137 (comment)

Let me close it first, open it when the day we start doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants