Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal SMARTS with only the Core Dependencies #78

Closed
Gamenot opened this issue Oct 26, 2020 · 3 comments
Closed

Minimal SMARTS with only the Core Dependencies #78

Gamenot opened this issue Oct 26, 2020 · 3 comments
Labels

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Oct 26, 2020

Add a minimum setup option that only contains the packages needed to run the most basic SMARTS scenarios.

The examples should be modularised with their own separate requirements so that their dependencies do not pollute the core of SMARTS.

@davidrusu
Copy link
Contributor

  • examples should have requirements.txt next to example files
/examples
  /rllib_agent
    - requirements.txt
    - ...
  /open_agent
    - requirements.txt
    - main.py
  • We have some very large dependencies, lets see if we can replace them with minimal packages that do just what we need.
    • scipy
    • sklearn
    • opencv

@liamchzh
Copy link
Contributor

Or we can have different modes for doing research and running SMARTS core.

@liamchzh liamchzh mentioned this issue Nov 6, 2020
4 tasks
@Gamenot Gamenot added this to the 0.5 milestone Dec 2, 2020
@Gamenot Gamenot modified the milestones: 0.5, 0.6 Dec 16, 2020
@Gamenot Gamenot added the ks label Jan 13, 2021
@Gamenot Gamenot modified the milestones: 0.6, Backlog Jan 27, 2021
@saulfield
Copy link
Contributor

Superseded by #1981.

@saulfield saulfield closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants