-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Help Request] Need to customize vehicle parameters #2116
Comments
|
Hello @Frzgunr1, I will look into this tomorrow to see what work would be involved. Do you have a specific model of truck you are looking for? The main resource requirement is a |
|
Hello @Frzgunr1, what is given in #767 is unfortunately just a set of visual models, it is still missing the dynamics model. The two current physics models are hardcoded in QuestionWhat is your timeline? |
InvestigationThere are a few components to a vehicle within our simulation.
Selection (via AgentInterface)Current vehicle selection is done in the agent interface: SMARTS/smarts/core/agent_interface.py Lines 323 to 326 in c2ebaaa
And constrained: SMARTS/smarts/core/agent_interface.py Line 370 in c2ebaaa
This currently is resolved to a Lines 300 to 305 in c2ebaaa
VisualsThe vehicle state is where the visual representation of the vehicle is resolved and where the simulation is intended to redirect to the appropriate SMARTS/smarts/core/vehicle_state.py Lines 50 to 93 in c2ebaaa
It also looks like there is currently a bug that does not forward the visual vehicle configuration and default dimensions when generating agents: Lines 339 to 343 in c2ebaaa
This would normally be done through specifying Lines 58 to 70 in c2ebaaa
PhysicsThe physics is represented in the following way: BusSMARTS/smarts/core/models/bus.urdf Lines 1 to 135 in c2ebaaa
SedanSMARTS/smarts/core/models/vehicle.urdf Lines 1 to 135 in c2ebaaa
There appears to be a second bug related to vehicle selection in which the vehicle can only ever have the dimensions of the default Line 286 in c2ebaaa
Lines 248 to 266 in c2ebaaa
ControllerThe controller arguments are currently defined here: SMARTS/smarts/core/models/controller_parameters.yaml Lines 1 to 51 in c2ebaaa
It looks like there is a final bug where if a vehicle is replaced (rather than a new vehicle generated) no configuration is used and defaults to SMARTS/smarts/core/vehicle_index.py Line 462 in c2ebaaa
Lines 328 to 342 in c2ebaaa
Lines 52 to 57 in c2ebaaa
Configuration is intended to be provided such as with a newly generated vehicle: Lines 322 to 330 in c2ebaaa
|
Result
|
Hi @Gamenot , you're right, thank you very much for your analyses, they are very accurate and readable, you're a great engineer. |
@Frzgunr1 I am about to start work on this, is there a particular grade of truck you are looking for?
Alternatively, the truck (7.1m 2.4m 2.4m) as is defined by SUMO. |
Sure,just use the truck (7.1m) as is defined by SUMO. |
High Level Description
Version
ver [1.4.0]
Operating System
ubuntu 20.04
Problems
No response
The text was updated successfully, but these errors were encountered: