[connect-tcp] Move capsule negotiation into the Upgrade Token #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSchinazi
approved these changes
Oct 21, 2024
draft-ietf-httpbis-connect-tcp.md
Outdated
|
|
||
| Server support for the Capsule Protocol is REQUIRED. Servers MUST confirm use of the Capsule Protocol by echoing the "Capsule-Protocol: ?1" header in their response. | ||
| Clients of this specification MAY implement "connect-tcp", "connect-tcp-capsule", or both. Accordingly, templated TCP proxy servers for arbitrary clients MUST implement both Upgrade Tokens. |
There was a problem hiding this comment.
I don't see why servers MUST implement both. One solution could be to use SHOULD instead (see below). Another option would be to add a sentence saying that servers that only expect one kind of client MAY only implement one of these Upgrade Tokens.
Suggested change
| Clients of this specification MAY implement "connect-tcp", "connect-tcp-capsule", or both. Accordingly, templated TCP proxy servers for arbitrary clients MUST implement both Upgrade Tokens. | |
| Clients of this specification MAY implement "connect-tcp", "connect-tcp-capsule", or both. Accordingly, templated TCP proxy servers for arbitrary clients SHOULD implement both Upgrade Tokens to improve compatibility. |
There was a problem hiding this comment.
OK, I've rephrased this to highlight an exemption for restricted deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2922