Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak the example in the explanation of "Lax-allowing-unsafe" #2812

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Tweak the example in the explanation of "Lax-allowing-unsafe" #2812

merged 4 commits into from
Jul 9, 2024

Conversation

b---c
Copy link
Contributor

@b---c b---c commented Jun 27, 2024

minimalist attempt at a fix for #2791

@bc-pi bc-pi mentioned this pull request Jun 27, 2024
Closed
@b---c b---c linked an issue Jun 27, 2024 that may be closed by this pull request
[RFC6265bis WGLC] Lax-allowing-unsafe narrative #2791
Closed
mikewest
mikewest approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sbingler
sbingler reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@sbingler sbingler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made some suggestions around the 2 min rule (plus some minor grammatical ones)

draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Show resolved Hide resolved
@b---c
Copy link
Contributor Author

b---c commented Jun 28, 2024

Thanks for the review @sbingler! I've incorporated all your suggestions.

@b---c b---c added 6265bis 6265bis samesite RFC6265bis's `SameSite` cookie attribute. labels Jun 28, 2024
sbingler
sbingler approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@sbingler sbingler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll wait for @mikewest to take another look before merging

mikewest
mikewest approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up on things after being out sick: this still LGTM. :)

@bc-pi
Copy link
Contributor

bc-pi commented Jul 8, 2024 •
edited
Loading

Thanks @mikewest and @sbingler! I dare say it's okay merge? (thinking about the I-D submission cutoff in a few hours but admittedly don't know what else could/should go into -15 or if publishing that today is even on the table)

@sbingler sbingler merged commit ffe9a44 into main Jul 9, 2024
2 checks passed
@sbingler sbingler deleted the 6265bis-lax-unsafe-example branch July 9, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest mikewest approved these changes

@sbingler sbingler sbingler approved these changes

@johnwilander johnwilander Awaiting requested review from johnwilander johnwilander is a code owner

Assignees
No one assigned
Labels
6265bis samesite RFC6265bis's `SameSite` cookie attribute. 6265bis
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC6265bis WGLC] Lax-allowing-unsafe narrative
4 participants
@b---c @bc-pi @mikewest @sbingler