Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for compatibility with typelevel scala #942

Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Feb 21, 2017

Takes scalaOrganization, but I don't think we have any crossbuild. I think this would be a different publication, and probably should also effect scala xml, but I wanted to put it out there for compatibility.

typelevel/scala#135

@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

Merging #942 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #942     +/-   ##
=========================================
+ Coverage   68.88%   68.99%   +0.1%     
=========================================
  Files         243      243             
  Lines        5461     5461             
  Branches      596      596             
=========================================
+ Hits         3762     3768      +6     
+ Misses       1699     1693      -6
Impacted Files Coverage Δ
core/src/main/scala/org/http4s/HttpVersion.scala 93.75% <ø> (-6.25%)
core/src/main/scala/org/http4s/Uri.scala 85.45% <ø> (+1.81%)
...src/main/scala/org/http4s/client/PoolManager.scala 46.96% <ø> (+3.03%)
.../scala/org/http4s/testing/ArbitraryInstances.scala 80% <ø> (+26.66%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3f8c0...628c3ea. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does macroParadiseSettings need CrossVersion.patch, too?

@ChristopherDavenport
Copy link
Member Author

I think you are correct. I had it in my PR to fs2. I'll update.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherDavenport ChristopherDavenport merged commit 3bcf935 into http4s:master Feb 22, 2017
@ChristopherDavenport ChristopherDavenport deleted the scalaOrganization branch February 22, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants