-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to hide or show Cache and Buffers in Graph mode #1540
base: main
Are you sure you want to change the base?
Conversation
The actual change looks good (should be one commit though, not two), but I'm not very eager about the feature overall. @fasterit @natoscott What do you think? |
I think for consistency reasons this switch should also affect the bar mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said on a comment this should also affect bar mode.
The cheap "NaN" stunt causes an assert failure:
stderr output >>>>>>>>>>
htop: Meter.c:409: Meter_humanUnit: Assertion `value >= 0.0' failed.
<<<<<<<<<< stderr output <<<<<<<<<<
The code also needs to save the setting to htoprc and print it in the crash handler (the Settings handling is incomplete).
I don't love it, as it adds yet another configurable option many people wont need and the Options menu is already cluttered. OTOH I don't see any better solution, so I wont object to it being added. |
This PR covers issue #407.
Added this option to "Display Options". It's enabled by default to be compatible with current behavior. Disabling it will remove Cache and Buffers memory from Memory Graph and Mem&Swp Graph.