Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request: Style Improvements #63

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hifocus
Copy link

@hifocus hifocus commented Dec 16, 2018

Hi. Thanks for developing htmlpreview/htmlpreview.github.com as a widely used tool on GitHub.

Today I tried to improve the style of this repo and found it good enough and worth for a pull request. My skills are poor so please do not mind if you don't like it.

Changes

  • I imported my own HTML Template for my organisation which is hxco/template to this project and customised it for a bit. Now it looks totally fine and a more straightforward vision.
  • I found that the original index.html does not have any <meta> tags for SEO. So I added some of them for you.
  • And also a nice logo from [iconfont.cn](http://iconfont.cn].

Deprecated

  • These two paragraphs:
    or prepend to the URL: http://htmlpreview.github.io/?https://github.com/twbs/bootstrap/blob/gh-pages/2.3.2/index.html or use this bookmarklet while browsing GitHub or BitBucket: HTMLPreview The reason for that is first I want to make the page as simple as possible so two many elements might not be good; second, currently, I don't think people just won't rely on bookmarks in comparison with the past.

Preview

I hope you are still having eyes on this old old project and consider to merge my pull request.

@niutech
Copy link
Collaborator

niutech commented Dec 16, 2018

Thanks for your work, but please keep in mind that index.html and its assets are being loaded on each invocation of https://htmlpreview.github.io/?https://...., so it should be as small as possible with no external assets (such as Spectre). Could you please make it more lightweight, include only used CSS, etc? Thanks!

@hifocus
Copy link
Author

hifocus commented Dec 16, 2018

Hi. Thanks for the suggestion. Spectre.css is a super lightweight CSS Framework. And I load it though jsDelivr, which is a global-optimised CDN.

image

Please see screenshot below, under a normal home bandwidth environment, the spectre.css can be loaded within less than 1 seconds. So I would believe that it would not have obvious effect with the general loading speed.

Please re-consider my pull request. Thanks!

@scarrrr316
Copy link

YQL api service has shut down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants