Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RPM upload GHA #587

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix RPM upload GHA #587

merged 2 commits into from
Sep 21, 2023

Conversation

brianhlin
Copy link
Collaborator

No description provided.

@brianhlin
Copy link
Collaborator Author

FWIW, we probably should just not use /usr/sbin/init as PID 1 in the container. I don't think it really matters what proc it is so we could probably just use /bin/sh but that's something that can be left for later

@matyasselmeci
Copy link
Contributor

Why do you need --privileged?

@matyasselmeci
Copy link
Contributor

You're not starting any services. Don't even specify a command to docker run; you'll get the default shell.

@timtheisen
Copy link
Member

Otherwise the EL9 container does not stay running.

timtheisen
timtheisen approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@timtheisen timtheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@matyasselmeci
Copy link
Contributor

Otherwise the EL9 container does not stay running.

What is the error message you get?

@timtheisen timtheisen merged commit 52ef981 into htcondor:V6-branch Sep 21, 2023
18 checks passed
@timtheisen
Copy link
Member

Error response from daemon: Container 497247badd539902a91fab1a202f33dcb8b108303e8f8c1348c1ac0ede441b6d is not running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtheisen timtheisen timtheisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhlin @matyasselmeci @timtheisen