Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to ionic v4, #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mixuala
Copy link

@mixuala mixuala commented Feb 15, 2019

  • add support for ionic css4 color classes

I'm not sure how to update your npm package, but these changes worked for my ionic 4 project

- add support for ionic css4 color classes
@hsuanxyz hsuanxyz self-requested a review February 15, 2019 07:20
@gezquinndesign
Copy link

Hey @mixuala - any ideas how I can get your package into my project via npm? Thanks

@mixuala
Copy link
Author

mixuala commented Mar 20, 2019 via email

@gezquinndesign
Copy link

So, how do I get the component? I've ran the build script on your repo but it fails because it's looking for the Angular 4 references - should I update the package.json in your repo before building the package? Apologies for the noobiness.

@mixuala
Copy link
Author

mixuala commented Mar 21, 2019

all my changes were in the /ion-tags-input folder. You can create a new ionic4 project and copy that folder to src/app/components/ion-tags-input/. I use this src/app/components/component.modules.ts for importing components:

import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { IonicModule } from '@ionic/angular';

import { IonTag } from "./ion-tags-input/ion-tag";
import { IonTagsInput } from "./ion-tags-input/ion-tags-input";

@NgModule({
  imports: [
    CommonModule,
    FormsModule,
    IonicModule.forRoot(),
    ReactiveFormsModule,
  ],
  declarations: [
    IonTagsInput, IonTag,
  ],
  exports: [
    IonTagsInput, IonTag,
  ],
  entryComponents: [IonTagsInput, IonTag,],
})
export class ComponentsModule {}

then just import the ComponentsModule in any NgModule where you use the Component

something like this:

https://stackblitz.com/edit/ionic-v4-beta7-ion-tags-input

@monsieurPaon
Copy link

Up, it's possible to merge this please ??

Copy link

@Fayozjon Fayozjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update ionic 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants