-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to ionic v4, #29
base: master
Are you sure you want to change the base?
Conversation
- add support for ionic css4 color classes
Hey @mixuala - any ideas how I can get your package into my project via npm? Thanks |
It's been a long time since I last built an NPM package. It's possible and
if you know how, it's easy. But easier is just to add the component
directly to your project.
…On Thu, Mar 21, 2019 at 4:30 AM Gez Quinn ***@***.***> wrote:
Hey @mixuala <https://github.com/mixuala> - any ideas how I can get your
package into my project via npm? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aed57Sz0WFx20DAmQRBunngcO40nzaMrks5vYpp9gaJpZM4a80j6>
.
|
So, how do I get the component? I've ran the build script on your repo but it fails because it's looking for the Angular 4 references - should I update the package.json in your repo before building the package? Apologies for the noobiness. |
all my changes were in the
then just import the something like this: |
Up, it's possible to merge this please ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update ionic 4
I'm not sure how to update your npm package, but these changes worked for my ionic 4 project