-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networked tags! #291
base: preview
Are you sure you want to change the base?
Networked tags! #291
Conversation
This is essentially good to go as-is, but there are still some additional features I'm looking to get in as long as time permits! |
Um, goes without saying, but to say it anyway... this has been on pause pending a probably light refresh and a good, fresh look-over. It'll take some rebasing work and catching up (especially #319). We're coming back to it quite soon, just not at this immediate moment! It is worth mentioning that the work on this PR was spiritually foundational (and in various ways, technologically, as well) to basically all recent work and feature additions. It's kind of ridiculous to believe this came together over practically eight days. |
6e757f2
to
79ed053
Compare
79ed053
to
e896fb4
Compare
Alright, there's probably still a good amount of touching up to do here (on code and maybe some design), but a lot of the foundations turned out to be quite solid, and this has been neatly rebased onto all the latest |
6afd154
to
2da0ce0
Compare
38c8fb7
to
1ce19d9
Compare
cover arts -> artworks, add lazy to cover grid
d359668
to
f03f863
Compare
f03f863
to
16c9fb3
Compare
Development:
Builds on the existing tag system to add capabilities for interconnectedness, as well as other convenient details, all of which are displayed in an interactive manner on the existing tag gallery page as well as the new tag info page.
Direct Descendant Tags
field (directDescendantArtTags
). LikeReferenced Tracks
and the like, this is the only field which is used to completely define the tag network - reversals are computed dynamically.withAncestorArtTagBaobabTree
) and user interface (for examplegenerateArtTagAncestorDescendantMapList
) are built around this.Description
andExtra Reading URLs
fields (description
,extraReadingURLs
) to art tags, so that they're easier to identify - and so it's possible to link to other art tags which are contextually related, but semantically disconnected.Description
field supports the same<hr class="split">
syntax used in group descriptions and news entries, and a new component is introduced (generateQuickDescription
) to only display the shorter part (descriptionShort
) - by default! - on gallery pages. This component has also been added to group gallery pages![[tag:art-tag-directory]]
replacer has been updated to use a new component (linkArtTagDynamically
) which automatically swaps between linking to the tag's gallery page or info page depending on what page is currently being rendered. The default, like before, is to the gallery - it's just tag info pages that will automatically link to other tag info pages. (This hooks into the samepagePath
extra dependency that was exposed a while ago forgenerateFooterLocalizationLinks
.)linkExternal
) have been updated to support nicer messaging for links to Fandom and specifically MSPA wiki (still hard-coded, sorry!). The name of the linked wiki page will be parsed out of the URL and displayed, e.g. "MSPA Wiki (John Egbert)".<dl>
-style list. Siblings of a displayed direct ancestor of the current tag (i.e. the first branch along a path to the root) are all listed, so you can hop between sibling tags without navigating to the common ancestor in-between. To keep the map otherwise concise and readable, other siblings are aggressively abbreviated - displaying "(...3 other tags...)", for example.