-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crediting sources and new-style contributions in Official Discography #573
Draft
towerofnix
wants to merge
14
commits into
preview
Choose a base branch
from
new-contribs
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
force-pushed
the
new-contribs
branch
from
September 15, 2024 17:23
52172e7
to
b09d9b5
Compare
towerofnix
force-pushed
the
preview
branch
5 times, most recently
from
September 25, 2024 23:58
0b3e3fa
to
cebdf9f
Compare
towerofnix
force-pushed
the
new-contribs
branch
2 times, most recently
from
September 26, 2024 10:19
81df7a2
to
b46ba72
Compare
towerofnix
force-pushed
the
new-contribs
branch
from
October 4, 2024 13:35
ed0ae3d
to
ff18ef5
Compare
towerofnix
force-pushed
the
preview
branch
3 times, most recently
from
November 2, 2024 22:14
1dee4a1
to
811ae37
Compare
Mainly addressing annotations in `Artists` field in this commit.
Missing credits for the bonus track and we'll probably still come back to this file a bunch of times LOL
Not reviewed, this is from at least a month ago!!
No new wiki credits! Just lots of crediting sources. Also some links for Jan van den Hemel.
Just the MSPA crediting sources.
Still no wiki credits, but this fills out Bandcamp credits. It also adds credits from commentary snippets to both vol. 3 and vol. 2.
MSPA credits #3, all Bandcamp credits, and newsposts. Plus miscellany: - Some newspost credits for flashes (sources only, contributors not updated) - 2019(!) credits for Doctor (Original Loop)
Excerpts from commentary! Still no updated wiki credits, but this means all Vols. 1-4 are equally good to go to get those credits.
towerofnix
force-pushed
the
new-contribs
branch
from
November 20, 2024 02:10
d76ce72
to
47e5977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works alongside hsmusic/hsmusic-wiki#553 to add crediting sources across the entire Official Discography, and bases brand new / revisited credits, broken into writing/performing/etc, based on those credits.
HIVESWAP Act 1 OST is addressed separately, in #568.
Check our progress on Google Docs!