Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'The Easiest Way to Fall' and 'Classic Rap Break' #564

Draft
wants to merge 2 commits into
base: preview
Choose a base branch
from

Conversation

towerofnix
Copy link
Member

@towerofnix towerofnix commented Aug 1, 2024

This is another WIP branch, just filing for tracking (it used to live at nebula/fixes). Will need a closer look! Commit is from May 28, there's almost certainly nearby relevant discussion.

Merge alongside hsmusic/hsmusic-media#71!

for future commits to fit into

Yes I renamed the commit
Yes I . committed it twice
YES I RENAMED THE HEADING
@towerofnix
Copy link
Member Author

Full summary from Lan at #hsmusic-chat, TL;DR from then below:

  1. Stuff can keep referencing/sampling Upward Movement, don't move that over to another source.
  2. Still, some things referencing Upward Movement are probably samples, and vice versa. (Some are probably both and only listed as one atm.) Reviewing this is part of #466 Fix the samples, not specific to Upward Movement.
  3. Upward Movement samples Classic Rap Break (and in turn/indirectly The Easiest Way to Fall), not Amen, Brother.
  4. Reference/sample lists that include Amen, Brother may actually be sampling Upward Movement. (Probably none of them are sampling Classic Rap Break.) This is a review that's specific to the historical mis-connection between Upward Movement and Amen, Brother.

@towerofnix
Copy link
Member Author

Refer also to original report by Makin, #issuefication-zone.

@towerofnix towerofnix force-pushed the preview branch 3 times, most recently from 1dee4a1 to 811ae37 Compare November 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant