error-column matching

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to the "vscode-glsllint" extension will be documented in thi
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
+## [1.9.1]
+
+### Added
+
+- Since https://github.com/KhronosGroup/glslang/pull/3614, glslangValidator now outputs the error column as well. If `--error-column` is given among `glslangValidatorArgs`, then glsllint will display glsl errors under the correct column, not just at the start of the line
+
 ## [1.9.x]
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "vscode-glsllint",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "publisher": "dtoplak",
   "repository": {
     "type": "git",

src/features/glsllintProvider.ts

@@ -526,11 +526,15 @@ export class GLSLLintingProvider {
               }
 
               if (severity !== undefined) {
-                const matches = line.match(/(WARNING|ERROR):\s+(\d|.*):(\d+):\s+(.*)/);
-                if (matches && matches.length === 5) {
+                const matches = line.match(/(WARNING|ERROR):\s+([^:]+):(\d+)(?::(\d+))?:\s+(.*)/);
+                let errorcolumn = 0;
+                if (matches && matches.length === 6) {
+                  if (matches[4] !== null) {
+                    errorcolumn = parseInt(matches[4]);
+                  }
                   const errorline = parseInt(matches[3]);
-                  const message = matches[4];
-                  const range = new vscode.Range(errorline - 1, 0, errorline - 1, 0);
+                  const message = matches[5];
+                  const range = new vscode.Range(errorline - 1, errorcolumn, errorline - 1, errorcolumn);
                   const diagnostic = new vscode.Diagnostic(range, message, severity);
                   diagnostics.push(diagnostic);
                 }