Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move links for github/videos to bottom of cell #14

Closed
wants to merge 4 commits into from
Closed

Move links for github/videos to bottom of cell #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7306fde
Brought Github and Videos link to the bottom of the tutCard div. Chan…
richa2710 Oct 31, 2023
206c25c
removed unused iconStyleGit from tutcard.js
richa2710 Oct 31, 2023
4c1f22f
edited README
richa2710 Oct 31, 2023
5cc76ca
Moved the links for github and videos to the bottom
richa2710 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Implemented by Aniket as GSoC qualification task.

```bash
# once
npm install
npm install --force
# always
npm run develop
```
4 changes: 2 additions & 2 deletions src/components/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ const Footer = () => {
<a href="/">
{" "}
<StaticImage
src="../images/logo.png"
height={30}
src="../images/hsf.svg"
height={60}
alt="logo"
></StaticImage>
</a>
Expand Down
7 changes: 5 additions & 2 deletions src/components/tutcard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,24 @@ import { MdVideoLibrary } from "react-icons/md";

// markup
const Tutcard = ({ tut }) => {
const iconStyleVid={
color:'#FF0000',
};
return (
<div className="tutCard">
{/* GitHub and Videos links */}
<div className="additionals">
{tut.repository !== "" ? (
<a title="GitHub Repo" href={tut.repository}>
<AiFillGithub height={300} />
<AiFillGithub height={300}/>
<span style={{ marginLeft: "8px" }}>GitHub</span>
</a>
) : null}
</div>
<div className="videos">
{tut.videos !== "" ? (
<a title="Videos" href={tut.videos}>
<MdVideoLibrary height={300} />
<MdVideoLibrary height={300} style={iconStyleVid}/>
<span style={{ marginLeft: "8px" }}>Videos</span>
</a>
) : null}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ main {
}

footer {
margin-top: 3rem;
margin-top: 2rem;
background: #374151;
padding: 2rem 3rem;
color: #fff;
Expand Down
21 changes: 15 additions & 6 deletions src/styles/tutCard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ code {
}
.tutCard .tutCardText {
max-width: 60%;
color: #0077cc;
}

.tutCard .tutCardText p {
Expand All @@ -60,8 +61,8 @@ code {

.tutCard .additionals {
position: absolute;
top: 0.8rem;
right: 0.8rem;
bottom: 0.3rem;
left: 11.6rem;
display: flex;
justify-content: space-between;
align-items: flex-end;
Expand All @@ -79,8 +80,8 @@ code {

.tutCard .videos {
position: absolute;
top: 2.5rem;
right: 0.8rem;
bottom: 0.3rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this specification I wonder: If there's a lot of text in the box, will this end up on top of the text? Can you try this by modifying the data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! And the size of the box is also fixed. So it doesn't scale with the text
Screenshot 2023-12-04 at 10 05 41 AM

left: 22rem;
display: flex;
justify-content: space-between;
align-items: flex-end;
Expand Down Expand Up @@ -140,7 +141,15 @@ code {
width: 100%;
position: relative;
justify-content: flex-start;
top: 0;
right: 0;
bottom: 0;
left: 0;
}

.tutCard .videos {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate?

width: 100%;
position: relative;
justify-content: flex-start;
bottom: 10;
left: 0;
}
}