Move links for github/videos to bottom of cell #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged text color. Changed icon color. Changed logo to HSF logo in the footer.
klieret
approved these changes
Dec 4, 2023
| @@ -79,8 +80,8 @@ code { | |||
|
|
|||
| .tutCard .videos { | |||
| position: absolute; | |||
| top: 2.5rem; | |||
| right: 0.8rem; | |||
| bottom: 0.3rem; | |||
There was a problem hiding this comment.
With this specification I wonder: If there's a lot of text in the box, will this end up on top of the text? Can you try this by modifying the data?
There was a problem hiding this comment.
Right! And the size of the box is also fixed. So it doesn't scale with the text
klieret
reviewed
Dec 4, 2023
| left: 0; | ||
| } | ||
|
|
||
| .tutCard .videos { |
|
I think the easy way to do this is what I had started in #5, which also solves all issues related to text wrapping etc. I'm going to close this, it's better to start fresh. Sorry for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the links for Github and Videos at the bottom of each cell.
Closes #2