-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plot quality for jupyter-notebooks #15
Conversation
Thanks for opening your first pull request here! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see https://hepsoftwarefoundation.org/workinggroups/training.html). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days. |
Hi @amanmdesai : Thank you for this. I'm a bit unsure about this, because it seems like a bit of a matter of taste? (I usually stick with the default 100dpi) Also in general unsure about how we want to continue the development of this repository, see hsf-training/hsf-training-matplotlib#66 -- your change might currently be easily overwritten the next time someone manually copies everything here) |
Hi, Since there is a discussion in hsf-training/hsf-training-matplotlib#66, we can discuss about the image quality later at some later stage. Thanks. |
This should be the same images as included in the webpage, right? |
Yes, the same images. The quality of images on webpage will need to be improved as well. |
Is there any specific one that you find particularly problematic? Because for me this is still an acceptable compromise... (and increasing the dpi 3-fold will mean an almost 10x increase in file sizes...) |
Ah, 10 fold is quite a increase in the file size. In that case, its no use to improve the quality. |
(That's my naive calculation because 3*3 = 9 ~ 10 for the 3-fold increase in dpi) |
Right. Shall I close this pull request? |
Yeah, I'm in favor of it (though I'm sorry because you spent time on it) |
Oh no problem. I should have checked the file size. Thanks. |
I have added
plt.rcParams['figure.dpi'] = 300
to the jupyter-notebooks which will improve the quality of images.