Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some post-teaching fixes #72

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: some post-teaching fixes #72

merged 1 commit into from
Jul 29, 2024

Conversation

henryiii
Copy link
Contributor

Quick fixes after teaching.

I think there was something else, @jpivarski?

@henryiii
fix: some post-teaching fixes
6f5315d 
Signed-off-by: Henry Schreiner <[email protected]>
jpivarski
jpivarski approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a statement about Uproot not being able to write remotely over a network.

Also, the file source could not be reliably be accessed. But that will involve moving the file to a better place (and preferably HTTP, rather than XRootD).

@eduardo-rodrigues eduardo-rodrigues merged commit bcf2cc0 into hsf-training:main Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

@eduardo-rodrigues eduardo-rodrigues eduardo-rodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @jpivarski @eduardo-rodrigues