Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04-awkward.md #62

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Update 04-awkward.md #62

merged 2 commits into from
Dec 6, 2023

Conversation

GuillermoFidalgo
Copy link
Contributor

added hint and solution block for awkward quizz

added hint and solution block for awkward quizz
Copy link

welcome bot commented Dec 4, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@GuillermoFidalgo
Copy link
Contributor Author

This PR should close #27

Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

@klieret klieret merged commit 5745fac into main Dec 6, 2023
3 checks passed
Copy link

welcome bot commented Dec 6, 2023

Congrats on merging your first pull request 🎉! We greatly appreciate it.
You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you might also be eligible to add yourself there.

@klieret klieret deleted the GuillermoFidalgo-patch-1 branch December 6, 2023 19:08
@klieret
Copy link
Member

klieret commented Dec 6, 2023

Good to have this fixed!

@GuillermoFidalgo Small tip: If you write "Closes #27" in the description of either the commit or PR, it will automatically close the issue.

Also, don't forget to fill in a commit title ;)

@GuillermoFidalgo
Copy link
Contributor Author

It has to be exactly the phrase?

"Closes #27"
I thought what I wrote did that already.

@klieret
Copy link
Member

klieret commented Dec 6, 2023

Ah, perhaps that was my bad, but I thought I didn't see the issue linked and thought the phrasing wasn't precise enough.

I'd be interested in this as well!

I remember it had to be exactly one of "closes" or "fixes" in the past, but I think they loosened it up more since then.

I'll experiment!

@GuillermoFidalgo
Copy link
Contributor Author

Interesting, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants