Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lessons #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

YarelisAcevedo
Copy link
Collaborator

Added setup for the lesson

Additionally added instructions for Python3 (my case) just in case any student has the same issue running any code

Introduction

Erased most of the original info, and updated it. Used more technical language for it and added an image (gave link for the resource)

Assertions and Exceptions

Corrected some info + example
Added Exceptions on the episode
Small exercise needs to be fixed (more clear instructions?)
Its too long, probably I need to shorten the episode

Unit_Testing, Testing with Pytest and Fixtures

Fixed the import * on all of the code and changed the exercise to be instead of using Jupyter Notebooks, to do them using the terminal
Didn't do much on them, so probably also needs to be a little more cleaned

Thank you! <3

@welcome
Copy link

welcome bot commented May 25, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

_episodes/02-assertions_exeptions.md Outdated Show resolved Hide resolved
_episodes/02-assertions_exeptions.md Show resolved Hide resolved
_episodes/02-assertions_exeptions.md Outdated Show resolved Hide resolved
_episodes/02-assertions_exeptions.md Outdated Show resolved Hide resolved
The advantage of assertions is their ease of use. They are rarely more than one
line of code. The disadvantage is that assertions halt execution
indiscriminately and the helpfulness of the resulting error message is usually
quite limited.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add custom error messages to them: assert False, "this will be displayed"

_episodes/04-Testing_w_Pytest.md Outdated Show resolved Hide resolved
_episodes/02-assertions_exeptions.md Outdated Show resolved Hide resolved
_episodes/03-Unit_Testing.md Outdated Show resolved Hide resolved
_episodes/03-Unit_Testing.md Outdated Show resolved Hide resolved
_episodes/05-Fixtures.md Outdated Show resolved Hide resolved
_episodes/01-Introduction.md Show resolved Hide resolved
_episodes/01-Introduction.md Outdated Show resolved Hide resolved
_episodes/01-Introduction.md Outdated Show resolved Hide resolved
_episodes/01-Introduction.md Show resolved Hide resolved
_episodes/05-Fixtures.md Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Aug 11, 2023

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Aug 11, 2023
#FIXME
## Setup Python

Make sure that you have the latest Python installed. The latest Python released is `Python 3.11.3`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explicit version adds maintenance burden. Use fixed link to the latest version, e.g. https://www.python.org/downloads/.

But this is also incorrect. We should not expect that this training only works with the latest python version. We should include a requirement that at least python 3.11 is needed, if that is the case.

```bash
python –version
```
- or if you have Python3:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.x is required for this training, and PEP 394 requires all Python 3.x to provide python3, so I'd just write the test for only that command.

```bash
python3 –version
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd refer to installation instructions at https://swcarpentry.github.io/python-novice-inflammation/#install-python instead of providing installation instructions here.

@stale stale bot removed stale labels Aug 12, 2023
@stale
Copy link

stale bot commented Oct 12, 2023

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants