Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce image size in episodes #144

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

fix: reduce image size in episodes #144

wants to merge 4 commits into from

Conversation

amangoel185
Copy link
Member

Fixes #60

@amangoel185 amangoel185 requested a review from klieret October 7, 2022 17:54
klieret
klieret requested changes Oct 7, 2022
View reviewed changes
_episodes/01-introduction.md
@@ -38,8 +38,7 @@ plt.show() # Show the figure

This code produces the following figure:

<!-- ![basic_plot](https://matplotlib.org/stable/_images/sphx_glr_usage_002.png) -->
![basic_plot](https://matplotlib.org/3.5.1/_images/sphx_glr_usage_001_2_0x.png)
![basic_plot](https://matplotlib.org/3.5.1/_images/sphx_glr_usage_001_2_0x.png){:width="50%"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'd imagine something like max-width would work better here. Else it will be very small when viewing the page in split-screen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what would be the syntax for max-width that would work here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I wonder. Maybe the {:width} thing is arbitrary html attribute injection though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does {:max-width=xxxpx} work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we can inject classes, so worst case would be to define a CSS class and then assign that

@klieret
Copy link
Member

klieret commented Oct 7, 2022

Thanks a lot for working on this :)

@stale
Copy link

stale bot commented Dec 6, 2022

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klieret klieret klieret requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce size of images in the module
2 participants
@amangoel185 @klieret