Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inclusion of plausible script #71

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix inclusion of plausible script #71

merged 2 commits into from
Nov 14, 2023

Conversation

klieret
Copy link
Member

@klieret klieret commented Nov 13, 2023 •
edited
Loading

Currently it puts

        <script><script defer data-domain="hepsoftwarefoundation.org" src="https://views.scientific-python.org/js/script.js"></script></script>

I hope this will fix it, but full disclaimer, I didn't test locally (because I didn't get it to build)

@klieret klieret requested a review from jonas-eschle November 13, 2023 22:43
jonas-eschle
jonas-eschle approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's see, feel free to merge

@klieret klieret merged commit 1096f5a into master Nov 14, 2023
1 check passed
@klieret klieret deleted the fix-plausible branch November 14, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-eschle jonas-eschle jonas-eschle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klieret @jonas-eschle