Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional floor types #327

Closed
wants to merge 256 commits into from
Closed

Allow additional floor types #327

wants to merge 256 commits into from

Conversation

bpark1327
Copy link
Contributor

@bpark1327 bpark1327 commented Jun 28, 2022 •
edited
Loading

Fixes #321

Renames FrameFloors/FrameFloor to Floors/Floor

yzhou601 and others added 30 commits December 20, 2019 13:49
@yzhou601
Revert name changes
f7510cf
@yzhou601
revert its annotation
71f9392
@shorowit
Adds a few AdjacentTo enumerations useful for attached/multifamily ho…
a43da16 
…using.
@shorowit
Merge branch 'indirect_standby_loss' of https://github.com/hpxmlwg/hpxml
c696a2c 
 into v3_1
@shorowit
Merge branch 'within_infiltration_volume' of https://github.com/hpxml…
99e209a 
…wg/hpxml into v3_1
@shorowit
Merge branch 'attached_adjacent_to_enums' of https://github.com/hpxml…
403d3ce 
…wg/hpxml into v3_1
@shorowit
Merge branch 'compressor_type' of https://github.com/hpxmlwg/hpxml in…
3900447 
…to v3_1

# Conflicts:
#	schemas/HPXMLDataTypes.xsd
@yzhou601
Added unitlocation and ductlocation enumerations
157f59d
@yzhou601
alphabetic order
a8edb1b
@yzhou601
Merge branch 'attached_adjacent_to_enums' of https://github.com/hpxml…
da45aee 
…wg/hpxml into v3_1
@shorowit
Merge branch 'solar_collector_efficiency_units' of https://github.com…
1b79c0a 
…/hpxmlwg/hpxml into v3_1
@shorowit
Merge branch 'v3_1' of https://github.com/hpxmlwg/hpxml into v3_1
46a1fcd
@yzhou601
Add location element to dishwasher and cooking range
747eb50
@yzhou601
Merge branch 'attached_adjacent_to_enums' of https://github.com/hpxml…
087b81f 
…wg/hpxml into v3_1
@shorowit
Offer FractionOperable (0-1) instead of Operable (boolean) for Window…
6e7b80e 
…s/Skylights. Useful for when Window/Skylight area represents multiple windows.
@shorowit
Merge branch 'fraction_operable' of https://github.com/hpxmlwg/hpxml …
b52b8ef 
…into v3_1
@shorowit
Clarify that NumberofConditionedFloorsAboveGrade should include walko…
ceba55d 
…ut basements.
@shorowit
Merge branch 'ncfl_ag_documentation' of https://github.com/hpxmlwg/hpxml
e913da2 
 into v3_1
@shorowit
Merge branch 'dishwasher_label_fields' of https://github.com/hpxmlwg/…
bcfbe54 
…hpxml into v3_1
@shorowit
Merge branch 'dishwasher_label_fields' of https://github.com/hpxmlwg/…
6c1ebc8 
…hpxml into v3_1
@shorowit
Merge branch 'water_heating_extension' of https://github.com/hpxmlwg/…
c47e489 
…hpxml into v3_1
@shorowit
Merge branch 'ventilation_fan_quantity' of https://github.com/hpxmlwg…
4098d20 
…/hpxml into v3_1
@shorowit
Clarify description.
ba840c2
@shorowit
Merge branch 'fraction_operable' of https://github.com/hpxmlwg/hpxml …
ac3ae0f 
…into v3_1
@shorowit
Add deprecation note.
18f116e
@shorowit
Merge branch 'attached_adjacent_to_enums' of https://github.com/hpxml…
6e10005 
…wg/hpxml into attached_adjacent_to_enums
@shorowit
Merge branch 'performance_adjustment_docs' of https://github.com/hpxm…
b5fe358 
…lwg/hpxml into v3_1
@shorowit
Merge branch 'rimjoist_siding_color' of https://github.com/hpxmlwg/hpxml
df71d15 
 into v3_1
@joseph-robertson
Add data types for hot tubs.
3abe632
@joseph-robertson
Add base elements for hot tubs.
6fb0e4c
@bpark1327 bpark1327 self-assigned this Jun 28, 2022
@bpark1327 bpark1327 added this to the v4.0 milestone Jun 29, 2022
@bpark1327 bpark1327 changed the title Allow describing mass floors Allow additional floor types Jun 29, 2022
shorowit
shorowit reviewed Jun 29, 2022
View reviewed changes
schemas/HPXMLBaseElements.xsd Outdated Show resolved Hide resolved
schemas/HPXMLBaseElements.xsd Show resolved Hide resolved
@shorowit shorowit marked this pull request as ready for review July 11, 2022 16:45
shorowit
shorowit reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional thoughts:

schemas/HPXMLBaseElements.xsd Outdated Show resolved Hide resolved
@bpark1327
Copy link
Contributor Author

bpark1327 commented Jul 14, 2022 •
edited
Loading

Reopen the PR (#332)

@bpark1327 bpark1327 closed this Jul 14, 2022
@bpark1327 bpark1327 deleted the mass_floor branch July 14, 2022 15:58
@bpark1327 bpark1327 mentioned this pull request Jul 14, 2022
Merged
This was referenced Oct 14, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

Assignees

@bpark1327 bpark1327

Labels
breaking change enhancement schemas
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Allow describing mass floors
4 participants
@bpark1327 @shorowit @yzhou601 @joseph-robertson