Avs validation #1
Conversation
senthilkumar-muthusamy
commented
Mar 31, 2021
senthilkumar-muthusamy
commented
- Added admin settings for AVS CVN decline conditions
- Updated the front end code to perform reversal based on AVS and CVN result codes
| if (property_exists($response, 'cvvResultCode')) { | ||
| $details['cvv_response_code'] = $response->cvvResultCode; | ||
| if (property_exists($response, 'cavvResponseCode')) { | ||
| $details['cvv_response_code'] = $response->cavvResponseCode; |
There was a problem hiding this comment.
cvv and cavv represent two separate ideas. We need cvv in this case.
There was a problem hiding this comment.
updated the response code and message
| 'label' => 'AVS and CVV2 failed' | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
We should be using the individual AVS result codes instead of the gateway's general response code.
There was a problem hiding this comment.
@slogsdon from the available transit documents which you already shared, I found only these 2 result codes related to AVS/CVV, is there any other document available for the result codes?
There was a problem hiding this comment.
You're performing the comparison against the $response->avsResponseCode and $response->cvnResponseCode response properties, which is correct, but the codes in these properties align with the standard AVS/CVV codes (i.e. what I listed in the requirements doc and what you're using in other PRs, WooCommerce as an example)
There was a problem hiding this comment.
ok.. updated the result codes
| 'label' => 'AVS and CVV2 failed' | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
We should be using the individual CVV result codes instead of the gateway's general response code.
There was a problem hiding this comment.
ok.. updated the result codes
|
|
||
| if ($response->responseCode !== '00' || $response->responseMessage === 'Partially Approved') { | ||
| if ($response->responseCode !== '00') { |
There was a problem hiding this comment.
I think that the code inside the if statement will never be run because response code different than '00' throw an exception. An exception is thrown in checkResponse function (https://github.com/hps/php-sdk/blob/962f6826c5938ec9b7c13dbad911970c019057da/src/Gateways/TransITConnector.php#L573).
There was a problem hiding this comment.
@slogsdon shall we update the PHP SDK to allow the AVS failure code and handle this in plugin side
| <avs_decline_codes translate="label"> | ||
| <label>AVS Decline Condition</label> | ||
| <frontend_type>multiselect</frontend_type> | ||
| <source_model>hps_transit/source_avsresultcodes</source_model> |
There was a problem hiding this comment.
Should be:
<source_model>hps_transit/source_avsResultCodes</source_model>
There was a problem hiding this comment.
updated the model name
| <cvv_decline_codes translate="label"> | ||
| <label>CVV Decline Condition</label> | ||
| <frontend_type>multiselect</frontend_type> | ||
| <source_model>hps_transit/source_cvvresultcodes</source_model> |
There was a problem hiding this comment.
Should be:
<source_model>hps_transit/source_cvvResultCodes</source_model>
There was a problem hiding this comment.
updated the model name
| $declinedAvsCodes = Mage::getStoreConfig('payment/hps_transit/avs_decline_codes'); | ||
| $declinedCvnCodes = Mage::getStoreConfig('payment/hps_transit/cvv_decline_codes'); |
There was a problem hiding this comment.
Should be:
$declinedAvsCodes = explode(',', Mage::getStoreConfig('payment/hps_transit/avs_decline_codes'));
$declinedCvnCodes = explode(',', Mage::getStoreConfig('payment/hps_transit/cvv_decline_codes'));
There was a problem hiding this comment.
thanks.. I updated the code with explode function
| 'label' => 'AVS and CVV2 failed' | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
You're performing the comparison against the $response->avsResponseCode and $response->cvnResponseCode response properties, which is correct, but the codes in these properties align with the standard AVS/CVV codes (i.e. what I listed in the requirements doc and what you're using in other PRs, WooCommerce as an example)
