Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

109-163/Implement small changes #263

Merged
merged 6 commits into from
Jan 14, 2019
Merged

109-163/Implement small changes #263

merged 6 commits into from
Jan 14, 2019

Conversation

lassesteffen
Copy link
Contributor

Fixes #109 Fixes #163

@lassesteffen lassesteffen changed the title 109-163/filter vms for employees too 109-163/Implement small changes Jan 14, 2019
westphal-jan
westphal-jan requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@westphal-jan westphal-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo. The rest is fine.

spec/controllers/vms_controller_spec.rb Outdated
expect(get(:index)).to render_template('vms/index')
end

it 'returns only vms associated to current usera' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@lassesteffen lassesteffen merged commit 19c5e3c into dev Jan 14, 2019
@lassesteffen lassesteffen deleted the 109-163/login/implement-remaining-tasks branch January 14, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westphal-jan westphal-jan westphal-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lassesteffen @westphal-jan