-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user membership management to group management #219
Conversation
We've tried implementing the feature through a form which is supposed to call the add_user method in the group controller. Unfortunately this method is not called through. Maybe validate the resource and check if the form is correct |
Unfortunately, I don't have a second user account to test this feature; is there any easy way to add a new user to the database? |
"form: {class: ..." is needed as button_to generates a form which wont be displayed inline otherwise Co-authored-by: Niklas Schilli <[email protected]>
Whats still missing is
|
I implemented the idea of moving the user management logic into a separate controller. But there is still duplicated code left, because sharing code between controllers seems to be non-trivial. I already looked into using Concerns. Before using a separate controller, I also experimented with other solutions to our problem. But in the end, just pointing the routes to the new |
When a user is not found, an alert should be shown instead of a notice. I added that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone could quickly look over my changes, we're good to merge!
I can't explicitly approve my own pr, but everything looks good to me. At least with refactorings tracked in #346 and in #353. |
Co-authored-by: Malte S. <[email protected]>
closes #106