Refactor: Move default values in TCCAuthHandler to class side (#419)

* Moving default values to class side
hpi-swa-teaching · Jun 28, 2021 · 365c3b9 · 365c3b9
1 parent 6cc39b7
commit 365c3b9
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 22 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1 @@
 .DS_STORE
-/.idea
diff --git a/.../TCCAuthHandler.class/instance/apiHash.st → ...AuthHandler.class/class/defaultApiHash.st b/.../TCCAuthHandler.class/instance/apiHash.st → ...AuthHandler.class/class/defaultApiHash.st
@@ -1,4 +1,4 @@
 default values
-apiHash
+defaultApiHash
 
 	^ '22a541245de1dcd1edd10ddb65f08aaa'
diff --git a/...ge/TCCAuthHandler.class/instance/apiID.st → ...CCAuthHandler.class/class/defaultApiID.st b/...ge/TCCAuthHandler.class/instance/apiID.st → ...CCAuthHandler.class/class/defaultApiID.st
@@ -1,4 +1,4 @@
 default values
-apiID
+defaultApiID
 
 	^ '4128597'
diff --git a/packages/TelegramClient-Core.package/TCCAuthHandler.class/instance/setTDLibParams.st b/packages/TelegramClient-Core.package/TCCAuthHandler.class/instance/setTDLibParams.st
@@ -8,8 +8,8 @@ setTDLibParams
 			'use_message_database' -> true.
 			'use_secret_chats' -> true.
 			'use_test_dc' -> self useTestDC.
-			'api_id' -> self apiID.
-			'api_hash' -> self apiHash.
+			'api_id' -> self class defaultApiID.
+			'api_hash' -> self class defaultApiHash.
 			'system_language_code' -> 'en'.
 			'device_model' -> 'Desktop'.
 			'system_version' -> self core client specificClient type.

diff --git a/packages/TelegramClient-Core.package/TCCAuthHandler.class/instance/useTestDC.st b/packages/TelegramClient-Core.package/TCCAuthHandler.class/instance/useTestDC.st
@@ -1,4 +1,4 @@
-default values
+accessing
 useTestDC
 
 	^ false
diff --git a/packages/TelegramClient-Core.package/TCCAuthHandler.class/methodProperties.json b/packages/TelegramClient-Core.package/TCCAuthHandler.class/methodProperties.json
@@ -1,9 +1,8 @@
 {
 	"class" : {
-		 },
+		"defaultApiHash" : "JB 6/26/2021 17:24",
+		"defaultApiID" : "JB 6/26/2021 17:23" },
 	"instance" : {
-		"apiHash" : "TR 4/27/2021 17:11",
-		"apiID" : "TR 4/27/2021 17:10",
 		"authState" : "R.S 5/18/2020 17:54",
 		"authState:" : "R.S 5/18/2020 17:54",
 		"checkAuthenticationCode:" : "RS 6/23/2021 16:35",
@@ -20,5 +19,5 @@
 		"logout" : "RS 6/23/2021 16:33",
 		"sendPhoneNumber:" : "RS 6/23/2021 16:34",
 		"setDBEncryptionKey:" : "RS 6/23/2021 16:35",
-		"setTDLibParams" : "RS 6/23/2021 16:15",
+		"setTDLibParams" : "JB 6/28/2021 10:14",
 		"useTestDC" : "rs 6/14/2020 12:40" } }
diff --git a/packages/TelegramClientTests-Core.package/TCTCCoreTests.class/instance/testAuthConstants.st b/packages/TelegramClientTests-Core.package/TCTCCoreTests.class/instance/testAuthConstants.st
@@ -2,5 +2,5 @@ testing
 testAuthConstants
 
 	self assert: TCCAuthHandler new useTestDC not.
-	self assert: TCCAuthHandler new apiHash isString.
-	self assert: TCCAuthHandler new apiID isString.
+	self assert: TCCAuthHandler defaultApiHash isString.
+	self assert: TCCAuthHandler defaultApiID isString.
diff --git a/packages/TelegramClientTests-Core.package/TCTCCoreTests.class/methodProperties.json b/packages/TelegramClientTests-Core.package/TCTCCoreTests.class/methodProperties.json
@@ -6,7 +6,7 @@
 		"partialGroupMembersTestFor:" : "RS 6/23/2021 16:00",
 		"receivedMessage" : "TR 6/2/2021 15:46",
 		"receivedMessage:" : "TR 6/2/2021 15:47",
-		"testAuthConstants" : "js 8/2/2020 22:54",
+		"testAuthConstants" : "JB 6/26/2021 17:24",
 		"testAuthHandler" : "per 5/21/2021 16:28",
 		"testBasicGroupMembers" : "per 6/10/2021 20:47",
 		"testCallback" : "per 5/21/2021 16:28",

diff --git a/...TestAuthHandler.class/instance/apiHash.st → ...AuthHandler.class/class/defaultApiHash.st b/...TestAuthHandler.class/instance/apiHash.st → ...AuthHandler.class/class/defaultApiHash.st
@@ -1,4 +1,4 @@
-accessing
-apiHash
+default values
+defaultApiHash
 
 	^ 'bda1c0b38033d2a5f2ce7e8ab06ef31a'
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/class/defaultApiID.st b/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/class/defaultApiID.st
@@ -0,0 +1,4 @@
+default values
+defaultApiID
+
+	^ '1733417'
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/instance/apiID.st b/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/instance/apiID.st
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/methodProperties.json b/packages/TelegramClientTests-Core.package/TCTCTestAuthHandler.class/methodProperties.json
@@ -1,7 +1,6 @@
 {
 	"class" : {
-		 },
+		"defaultApiHash" : "JB 6/26/2021 17:25",
+		"defaultApiID" : "JB 6/26/2021 17:25" },
 	"instance" : {
-		"apiHash" : "rs 6/14/2020 12:42",
-		"apiID" : "rs 6/14/2020 12:45",
 		"useTestDC" : "rs 6/14/2020 12:41" } }