Fix removal of user leaking permissions to public user #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olschulz
approved these changes
Aug 22, 2024
DavidSchroschk
approved these changes
Aug 22, 2024
Hatte ich auch schon geguckt, leider nicht :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the user was deleted before the user's permissions were looked up. The removal of the user cleared the
usercolumn of the user's permissions toNULL, so the lookup did not find any permissions and thus the public user (idNULL) received the deleted user's permissions. Now, the lookup (and deletion) of the permissions is done before the deletion of the user, which avoids this problem.