Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 pylint issues to check for #233

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

wdpypere
Copy link
Contributor

@wdpypere wdpypere commented Nov 2, 2023

While doing some cleanup I found that we have some small issues we could check for:

consider-using-dict-comprehension, consider-using-set-comprehension: both mostly leftover from python2 times, as they are less readably and use a transient list they are slower, I propose to fix those. (see https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/consider-using-set-comprehension.html and https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/consider-using-dict-comprehension.html)

implicit-str-concat: I found 2 instances of this, and both were typos which were unwanted behaviour. (https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/implicit-str-concat.html)

@stdweird stdweird merged commit 34bf3ea into hpcugent:master Nov 6, 2023
2 checks passed
@wdpypere wdpypere deleted the pylint branch November 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants