Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some cleanup I found that we have some small issues we could check for:
consider-using-dict-comprehension
,consider-using-set-comprehension
: both mostly leftover from python2 times, as they are less readably and use a transient list they are slower, I propose to fix those. (see https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/consider-using-set-comprehension.html and https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/consider-using-dict-comprehension.html)implicit-str-concat
: I found 2 instances of this, and both were typos which were unwanted behaviour. (https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/implicit-str-concat.html)