Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't remove setup.cfg #60

Merged
merged 1 commit into from
Nov 22, 2017
Merged

don't remove setup.cfg #60

merged 1 commit into from
Nov 22, 2017

Conversation

JensTimmerman
Copy link
Contributor

No description provided.

[bdist_rpm]
requires = python-vsc-accountpage-clients >= 0.9.0
python-vsc-base >= 2.4.16
python-vsc-config >= 1.31.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.35.3

@wdpypere wdpypere merged commit 163e0a8 into hpcugent:master Nov 22, 2017
@@ -0,0 +1,14 @@
[bdist_rpm]
requires = python-vsc-accountpage-clients >= 0.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more recent version?

@stdweird
Copy link
Member

@JensTimmerman why was this needed?

@JensTimmerman
Copy link
Contributor Author

JensTimmerman commented Nov 22, 2017

@stdweird this was accedentally removed in the last pr.
This is needed because without this pytz get's removed from the dependencies, and the machine, and the rpm is called pytz in redhat/fedora/centos, instead of python-pytz, as one (and vsc-install) would expect.
see

'makesetupcfg': False, # use setup.cfg provided to get pytz instead of python-pytz

and hpcugent/vsc-install#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants